More Array API changes #7067
Merged
More Array API changes #7067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic-arrays
Contributor
Author
|
This is great feedback - thanks @keewis! I will take a look at implementing your suggestions. |
tomwhite
force-pushed
the
more-array-api
branch
from
525c045 to
00a443f
Compare
Contributor
Author
|
Updated with all the suggestions. How does this look now? |
TomNicholas
approved these changes
Sep 28, 2022
Member
TomNicholas
left a comment
TomNicholas
left a comment
There was a problem hiding this comment.
Seems to me like all the comments have been addressed, nice!
tomwhite
force-pushed
the
more-array-api
branch
from
06e45fc to
3c45180
Compare
for more information, see https://pre-commit.ci
Contributor
|
Looks like we're good to go here with respect to pint. Thanks @tomwhite ! |
dcherian
reviewed
Oct 17, 2022
keewis
pushed a commit
to keewis/xarray
that referenced
this pull request
Oct 19, 2022
* More Array API changes, including aggregation with nans, astype, where, stack. * Add `reshape` to `duck_array_ops` * Simplify `as_shared_dtype` * Add `sum_where` to `duck_array_ops` * Remove unused `_replace_nan` function * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update xarray/core/duck_array_ops.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Deepak Cherian <[email protected]>
15 tasks
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including aggregation with nans, astype, where, stack.
This is a follow-on to #6804, delegating more functions to
nporxpas appropriate.