More correct deprecation warning for lock argument
#5256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexamici
changed the title
lock parameterlock argument
aurghs
approved these changes
May 4, 2021
max-sixty
approved these changes
May 4, 2021
Co-authored-by: Maximilian Roos <[email protected]>
TomNicholas
approved these changes
May 4, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lockkwarg needs a deprecation cycle? #5073 (alternative to and more precise than Add deprecation warnings for lock kwarg #5237)pre-commit run --all-fileswhats-new.rstapi.rst@TomNicholas and all, sorry again for addressing this late.