Remove the references to _file_obj outside low level code paths, change to _close

xarray/backends/rasterio_.py

@@ -350,8 +350,8 @@ def open_rasterio(filename, parse_coordinates=None, chunks=None, cache=None, loc
         dims=("band", "y", "x"),
         coords=coords,
         attrs=attrs,
-        close=manager.close,
     )
+    result.set_close(manager.close)
 
     if chunks is not None:
         from dask.base import tokenize

xarray/backends/store.py

@@ -33,7 +33,8 @@ def open_backend_dataset_store(
         decode_timedelta=decode_timedelta,
     )
 
-    ds = Dataset(vars, attrs=attrs, close=store.close)
+    ds = Dataset(vars, attrs=attrs)
+    ds.set_close(store.close)
     ds = ds.set_coords(coord_names.intersection(vars))
     ds.encoding = encoding
 

xarray/conventions.py

@@ -597,7 +597,8 @@ def decode_cf(
         use_cftime=use_cftime,
         decode_timedelta=decode_timedelta,
     )
-    ds = Dataset(vars, attrs=attrs, close=close)
+    ds = Dataset(vars, attrs=attrs)
+    ds.set_close(close)
     ds = ds.set_coords(coord_names.union(extra_coords).intersection(vars))
     ds.encoding = encoding
 

xarray/core/common.py

@@ -331,7 +331,9 @@ def get_squeeze_dims(
 class DataWithCoords(SupportsArithmetic, AttrAccessMixin):
     """Shared base class for Dataset and DataArray."""
 
-    __slots__ = ()
+    _close: Optional[Callable[[], None]]
+
+    __slots__ = ("_close",)
 
     _rolling_exp_cls = RollingExp
 
@@ -1264,9 +1266,11 @@ def where(self, cond, other=dtypes.NA, drop: bool = False):
 
         return ops.where_method(self, cond, other)
 
+    def set_close(self, close: Optional[Callable[[], None]]) -> None:
+        self._close = close
+
     def close(self: Any) -> None:
         """Close any files linked to this object"""
-        self._close: Optional[Callable[[], None]]
         if self._close is not None:
             self._close()
         self._close = None

xarray/core/dataarray.py

@@ -377,7 +377,6 @@ def __init__(
         # internal parameters
         indexes: Dict[Hashable, pd.Index] = None,
         fastpath: bool = False,
-        close: Optional[Callable[[], None]] = None,
     ):
         if fastpath:
             variable = data
@@ -423,7 +422,7 @@ def __init__(
         # public interface.
         self._indexes = indexes
 
-        self._close = close
+        self._close = None
 
     def _replace(
         self,
@@ -442,8 +441,9 @@ def _replace(
         if close is _default:
             close = self._close
         replaced = type(self)(
-            variable, coords, name=name, fastpath=True, indexes=indexes, close=close
+            variable, coords, name=name, fastpath=True, indexes=indexes
         )
+        replaced.set_close(close)
         return replaced
 
     def _replace_maybe_drop_dims(

xarray/core/dataset.py

@@ -665,7 +665,6 @@ def __init__(
         data_vars: Mapping[Hashable, Any] = None,
         coords: Mapping[Hashable, Any] = None,
         attrs: Mapping[Hashable, Any] = None,
-        close: Optional[Callable[[], None]] = None,
     ):
         # TODO(shoyer): expose indexes as a public argument in __init__
 
@@ -689,7 +688,7 @@ def __init__(
         )
 
         self._attrs = dict(attrs) if attrs is not None else None
-        self._close = close
+        self._close = None
         self._encoding = None
         self._variables = variables
         self._coord_names = coord_names
@@ -1343,8 +1342,8 @@ def _construct_dataarray(self, name: Hashable) -> "DataArray":
             name=name,
             indexes=indexes,
             fastpath=True,
-            close=self._close,
         )
+        da.set_close(self._close)
         return da
 
     def __copy__(self) -> "Dataset":
@@ -4808,8 +4807,8 @@ def to_array(self, dim="variable", name=None):
             attrs=self.attrs,
             name=name,
             indexes=indexes,
-            close=self._close,
         )
+        da.set_close(self._close)
         return da
 
     def _normalize_dim_order(