Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Codspeed broken with changes, temporarily reverting so we can do perf analysis in the meantime

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 22, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9980020
Status: ✅  Deploy successful!
Preview URL: https://6fb56c7c.pydantic-docs.pages.dev
Branch Preview URL: https://revert-codspeed-ci.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #10942 will degrade performances by 9.86%

Comparing revert-codspeed-ci (9980020) with main (ed29a35)

Summary

❌ 17 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main revert-codspeed-ci Change
test_efficiency_with_highly_nested_examples 719 µs 784.3 µs -8.33%
test_list_of_models_serialization 59.5 µs 63.5 µs -6.27%
test_model_json_serialization 60.5 µs 65.6 µs -7.78%
test_simple_model_serialization 32.6 µs 34.7 µs -6.24%
test_complex_model_validation[__init__] 54.4 µs 58.9 µs -7.78%
test_complex_model_validation[model_validate] 54.2 µs 59.4 µs -8.77%
test_list_of_models_validation[__init__] 94.3 µs 101.2 µs -6.83%
test_list_of_models_validation[model_validate] 92.1 µs 99.8 µs -7.73%
test_nested_model_validation[__init__] 56.7 µs 61.5 µs -7.9%
test_nested_model_validation[model_validate] 54.2 µs 58.8 µs -7.83%
test_simple_model_validation[__init__] 40 µs 42.3 µs -5.34%
test_simple_model_validation[model_validate] 41.2 µs 43.7 µs -5.89%
test_north_star_dump_python 15.9 ms 17 ms -7%
test_north_star_validate_json 53.4 ms 56.6 ms -5.67%
test_north_star_validate_json_strict 53.2 ms 56.4 ms -5.61%
test_north_star_validate_python 45.1 ms 48.2 ms -6.49%
test_north_star_validate_python_strict 27.2 ms 30.2 ms -9.86%

@sydney-runkle
Copy link
Contributor Author

@davidhewitt, I think we should revisit, I'm concerned this was due to v2.27.1 in pydantic-core...

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle sydney-runkle merged commit f9f4aee into main Nov 22, 2024
99 of 100 checks passed
@sydney-runkle sydney-runkle deleted the revert-codspeed-ci branch November 22, 2024 02:28
@sydney-runkle
Copy link
Contributor Author

Merging just so we can get codspeed going again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant