Skip to content

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Jul 18, 2023

Closes #786

Selected Reviewer: @dmontagu

@adriangb
Copy link
Member Author

please review

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #788 (9a68989) into main (33fea1e) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   93.67%   93.53%   -0.15%     
==========================================
  Files          99      100       +1     
  Lines       14322    14378      +56     
  Branches       25       25              
==========================================
+ Hits        13416    13448      +32     
- Misses        900      924      +24     
  Partials        6        6              
Impacted Files Coverage Δ
src/input/input_python.rs 98.11% <100.00%> (+0.01%) ⬆️

... and 68 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fea1e...9a68989. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 18, 2023

CodSpeed Performance Report

Merging #788 will not alter performance

Comparing str-lax (9a68989) with main (33fea1e)

Summary

✅ 126 untouched benchmarks

@adriangb
Copy link
Member Author

Pydantic test failures are expected, we're changing the behavior

@adriangb adriangb merged commit f38bea6 into main Jul 19, 2023
@adriangb adriangb deleted the str-lax branch July 19, 2023 13:38
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subclasses of str

3 participants