Skip to content

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jun 21, 2023

We have a crash when building artifacts on windows caused by #674.

It looks like #173 didn't apply for windows, but fortunately the regeneration of generate_self_schema.py was harmlessly using the main interpreter. After #674 the generation is now using the wrong interpreter.

This should fix properly by avoiding regeneration on Windows too.

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Jun 21, 2023
@davidhewitt davidhewitt force-pushed the dh/fix-schema-build branch from e11edc0 to 6acc1ea Compare June 21, 2023 14:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #682 (e11edc0) into main (a85cd36) will not change coverage.
The diff coverage is n/a.

❗ Current head e11edc0 differs from pull request most recent head 6acc1ea. Consider uploading reports for the commit 6acc1ea to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files          99       99           
  Lines       13802    13802           
  Branches       25       25           
=======================================
  Hits        12936    12936           
  Misses        860      860           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85cd36...6acc1ea. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 21, 2023

CodSpeed Performance Report

Merging #682 dh/fix-schema-build (6acc1ea) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 125 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@davidhewitt davidhewitt marked this pull request as ready for review June 21, 2023 14:53
@samuelcolvin samuelcolvin merged commit 7d6f97c into main Jun 21, 2023
@samuelcolvin samuelcolvin deleted the dh/fix-schema-build branch June 21, 2023 15:45
davidhewitt added a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt added a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Full Build cause CI to do a full build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants