-
Notifications
You must be signed in to change notification settings - Fork 309
Default validator #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Default validator #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b30ecf
to
efa00a8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 98.65% 98.54% -0.12%
==========================================
Files 48 49 +1
Lines 5057 5139 +82
Branches 35 36 +1
==========================================
+ Hits 4989 5064 +75
- Misses 68 75 +7
Continue to review full report at Codecov.
|
dce22a3
to
5a3f054
Compare
Merged
replaced by #242 to try to get codecov to work 😠. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing from #200, moving default and
on_error
behaviour into separate validator for reuse in other places.@PrettyWood this is ready to review and will be ready to merge soon. But I know you're busy so I'll probably merge once I'm happy unless anyone brings up problems.
TODO: