Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Aug 22, 2022

continuing from #200, moving default and on_error behaviour into separate validator for reuse in other places.

@PrettyWood this is ready to review and will be ready to merge soon. But I know you're busy so I'll probably merge once I'm happy unless anyone brings up problems.

TODO:

  • check performance doesn't get worse
  • support positional tuples
  • coverage

@samuelcolvin samuelcolvin marked this pull request as draft August 22, 2022 08:33
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #234 (288acb6) into main (cea60f8) will decrease coverage by 0.11%.
The diff coverage is 95.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   98.65%   98.54%   -0.12%     
==========================================
  Files          48       49       +1     
  Lines        5057     5139      +82     
  Branches       35       36       +1     
==========================================
+ Hits         4989     5064      +75     
- Misses         68       75       +7     
Impacted Files Coverage Δ
src/build_tools.rs 96.00% <0.00%> (-1.30%) ⬇️
src/errors/line_error.rs 97.18% <0.00%> (-1.39%) ⬇️
src/validators/date.rs 95.18% <0.00%> (-1.17%) ⬇️
src/validators/arguments.rs 99.17% <92.00%> (-0.83%) ⬇️
src/validators/typed_dict.rs 98.61% <96.96%> (-0.29%) ⬇️
src/validators/with_default.rs 98.61% <98.61%> (ø)
pydantic_core/schema_types.py 100.00% <100.00%> (ø)
src/errors/validation_exception.rs 98.00% <100.00%> (+0.02%) ⬆️
src/validators/mod.rs 98.34% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea60f8...288acb6. Read the comment docs.

@samuelcolvin samuelcolvin changed the title WIP, default validator Default validator Sep 21, 2022
@samuelcolvin samuelcolvin marked this pull request as ready for review September 21, 2022 11:37
@samuelcolvin samuelcolvin mentioned this pull request Sep 22, 2022
@samuelcolvin
Copy link
Member Author

replaced by #242 to try to get codecov to work 😠.

@samuelcolvin samuelcolvin deleted the default-validator branch September 22, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants