Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Fix pydantic/pydantic#10192

Now:

pydantic_core._pydantic_core.PydanticSerializationUnexpectedValue: Expected 3 fields but got 2 for field Pipeline of type `Side_with_init` with value `Side_with_init(Name='Remove', With_init='TestRemoveOptional')` - serialized value may not be as expected.

Before:

pydantic_core._pydantic_core.PydanticSerializationUnexpectedValue: Unexpected Value

Also:

  • Fixed bug where field_namewas nullified in extra for model serializers
  • Standardized truncating string logic via tools function

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially can benefit from a test?

Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #1415 will not alter performance

Comparing better-warning-for-missing-field (63f108d) with main (4113638)

Summary

✅ 155 untouched benchmarks

@BoxyUwU
Copy link
Contributor

BoxyUwU commented Aug 21, 2024

+1 to a test being nice, its hard to see what the change in output actually looks like in practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected serializer warning for Union with discriminator

3 participants