Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Implementing support for pydantic/jiter#101

@willbakst :)

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to clean up cache_strings at the same time 👍

Copy link

codspeed-hq bot commented Aug 5, 2024

CodSpeed Performance Report

Merging #1390 will not alter performance

Comparing trailing-strings (79a0e92) with main (cc2c46c)

Summary

✅ 155 untouched benchmarks

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this matches the jiter-python signature, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants