Skip to content

Conversation

@tlambert03
Copy link
Member

@tlambert03 tlambert03 changed the title run napari tests using napari workflow tests: run napari tests using napari workflow Oct 27, 2023
@tlambert03 tlambert03 changed the title tests: run napari tests using napari workflow test: run napari tests using napari workflow Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80c795e) 99.54% compared to head (8a9f5b6) 99.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          31       31           
  Lines        1746     1746           
=======================================
  Hits         1738     1738           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

@Czaki ... I'm a bit confused.

In the npe2 pr, you used:

  test_napari:
     name: napari tests
     uses: czaki/napari/.github/workflows/test_external_package_workflow.yml@feature/test_against_napari
  • it kinda seems like test_external_package_workflow is just a workflow to test the real workflow which is reusable_run_tox_test ...
  • when I use it here, it looks like it's just pulling in npe2 (and not app-model)

is that correct? should I be switching it to reusable_run_tox_test here? and should you be switching it to that in napari/npe2#322 as well?

@tlambert03
Copy link
Member Author

hmmm... but then if I do that, it doesn't test against both HEAD and release of napari, which I gathered was the point. I'll wait for you to tell me what I've misunderstood :)

@Czaki
Copy link
Contributor

Czaki commented Oct 29, 2023

Short summary.
There was a bug in workflow file (wrong if) that lead to the pulling of npe2 instead of the proper repository. It is fixed. To get a proper working workflow, it is required to restart workflows with a new commit (otherwise, GitHub will select old workflow version). I suggest git commit -m "trigger ci" --allow-empty

The idea is to test against the latest release and the current main. But this workflow requires updating tox configuration to allow the install dependency from the repository. So the current version tests against branch v0.4.19x (current rc) and main_test, the branch with modification of tox.ini.

When PR is merged to napari/napari repository it will be tested against main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants