-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ROB: Skip Go-To actions without a destination #3420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stefan6419846
merged 3 commits into
py-pdf:main
from
badGarnet:fix/issue-3419-check-if-key-exists-before-create-link
Aug 5, 2025
Merged
ROB: Skip Go-To actions without a destination #3420
stefan6419846
merged 3 commits into
py-pdf:main
from
badGarnet:fix/issue-3419-check-if-key-exists-before-create-link
Aug 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 55 55
Lines 9340 9342 +2
Branches 1708 1709 +1
=======================================
+ Hits 9058 9060 +2
Misses 168 168
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
stefan6419846
added a commit
that referenced
this pull request
Aug 11, 2025
## What's new ### Security (SEC) - Limit decompressed size for FlateDecode filter (#3430) by @stefan6419846 ### Deprecations (DEP) - Drop Python 3.8 support (#3412) by @stefan6419846 ### New Features (ENH) - Move BlackIs1 functionality to tiff_header (#3421) by @j-t-1 ### Robustness (ROB) - Skip Go-To actions without a destination (#3420) by @badGarnet ### Developer Experience (DEV) - Update code style related libraries (#3414) by @stefan6419846 - Update mypy to 1.17.0 (#3413) by @stefan6419846 - Stop testing on Python 3.8 and start testing on Python 3.14 (#3411) by @stefan6419846 ### Maintenance (MAINT) - Cleanup deprecations (#3424) by @stefan6419846 [Full Changelog](5.9.0...6.0.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3419 by checking if key
/D
exists in a link object before creating link referencing this key.test
A minimum test file is added and a test is added to this PR. Without this change the test will yield
KeyError
.