Skip to content

Conversation

@Ahanmr
Copy link
Contributor

@Ahanmr Ahanmr commented Apr 14, 2020

  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse
Copy link
Member

cwhanse commented Apr 14, 2020

Hi @Ahanmr text looks fine. Can you add this to #936 instead of in a new PR?

@wholmgren
Copy link
Member

I suggest changing the title of this PR to be more descriptive and merging both of them for expediency.

@cwhanse
Copy link
Member

cwhanse commented Apr 16, 2020

I'd guess the frequent get_psm3 and other test failures are rather discouraging for contributors.

@cwhanse cwhanse changed the title Updated whatsnew v0.7.2 Updated whatsnew for PR #936 Apr 16, 2020
@mikofski mikofski mentioned this pull request Apr 16, 2020
@CameronTStark CameronTStark merged commit 85eeaa7 into pvlib:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants