Skip to content

Conversation

@AdamRJensen
Copy link
Member

  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR adds the map_variables keyword to the pvlib.iotools.get_srml and pvlib.iotools.read_srml functions. These functions already were mapping the variables, but this PR gives the option of setting map_variables=False.

The main driver for this PR was to make the functions follow the standard pattern and to change the mapping of wind direction to wind_direction where it was previously mapped to wind_dir.

@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels Jun 13, 2023
@AdamRJensen AdamRJensen added this to the 0.10.0 milestone Jun 13, 2023
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a whatsnew entry

@kandersolar kandersolar merged commit 100bc17 into pvlib:main Jun 13, 2023
@AdamRJensen AdamRJensen deleted the correct_wind_speed_name_read_srml branch June 30, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

io remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants