Added custom effect text #263
Merged
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2017 11:29
punker76
requested changes
Nov 1, 2017
| /// </summary> | ||
| public string EffectText { get; set; } | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you remove the extra empty line? thx
| { | ||
| switch (effect) | ||
| { | ||
| case DragDropEffects.All: | ||
| // TODO: Add default template for EffectAll | ||
| return GetEffectAllAdornerTemplate(target); | ||
| case DragDropEffects.Copy: | ||
| return GetEffectCopyAdornerTemplate(target) ?? CreateDefaultEffectDataTemplate(target, IconFactory.EffectCopy, "Copy to", destinationText); | ||
| return GetEffectCopyAdornerTemplate(target) ?? CreateDefaultEffectDataTemplate(target, IconFactory.EffectCopy, effectText == null ? "Copy to" : effectText, destinationText); |
There was a problem hiding this comment.
So maybe it's also good to check string.IsNullOrEmpty(effectText)
There was a problem hiding this comment.
We used to have the code like your suggestion but we needed an empty string instead of "move to".
With string.IsNullOrEmpty(effectText) the empty string would have been replaced with "Move to". A workaround would have been to set the effectText to " " but the additional whitespace doesn't look good.
There was a problem hiding this comment.
You're right, so it's ok for me.
punker76
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom effect text
I've added the feature to customize the text which pops up when you drag an item by adding an optional argument to the GetEffectAdornerTemplate function.
Before, you only could choose between "Move to", "Copy to", "Link to" and no text at all.
If you leave the string empty or null the default strings will be used.
I extended the IDropInfo interface with the EffectText string.