Add Orientation as attached property #155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to override which direction drag and drop works in.
…nings + Fix minor XML-documentation error
|
@jankrib Sorry for the very very late response... but is this property really necessary? Can you give me a nice sample? Thx! |
|
We needed it because we used gong drag drop on a grid. It is not clear for gong which direction to work on. This allowed us to have reordering of columns and rows in a table, but we needed this for it to work in both directions. Could be that this is a special case, but I don't see any downside with allowing direction to be explicitly set. |
| /// <summary> | ||
| /// Gets the index of the target item within <see cref="TargetCollection"/>. | ||
| /// </summary> | ||
| public int TargetIndex { get; private set; } |
There was a problem hiding this comment.
Why this? It's the same as InsertIndex.
Content elements such as runs within textblocks could not be used as drop target items, because they are not UIElements. This patch provides a way to use ContentElements as drop target items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to override which direction drag and drop works in.