Skip to content

Conversation

dhirajlaulkar
Copy link

  • Add packages/pug/test/rethrow-buffers.test.js with fixtures to ensure
    included sources are stored as strings when compileDebug is enabled,
    preventing pug_rethrow from calling .split on a Buffer
    (reproduces and guards against Generated debug_sources are node Buffers and fail pug_rethrow #3290).
  • Update packages/pug/test/error.reporting.test.js to accept both legacy
    and Node 16+ error message formats:
    • "Cannot read property 'length' of X"
    • "Cannot read properties of X (reading 'length')"

All test suites pass locally after these changes.

Refs: #3290

@rollingversions
Copy link

There is no change log for this pull request yet.

Create a changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant