Specify that Session.headers needs to be set to a OrderedDict in Header Ordering docs #6475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
approved these changes
Aug 12, 2023
Member
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
The OrderedDict requirement is a bit redundant now with Python 3, but I don't think we've actually evaluated if we have any special logic around this. For now I think fixing the incorrect link is useful until we consider rewriting this.
Thanks @joren485!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description.
Small improvement to the docs:
Session.headers(and notSession) should be set to anOrderedDictto preserve header order.