Skip to content

chore: Refactor delimiter_split() #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

chore: Refactor delimiter_split() #4257

merged 1 commit into from
Feb 28, 2024

Conversation

@cobaltt7
Copy link
Collaborator

Description

Slightly refactors delimiter_split() with the goal of lowering its complexity before #4248.

Checklist - did you ...

  • [-] Add an entry in CHANGES.md if necessary?
  • [-] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?

@cobaltt7 cobaltt7 mentioned this pull request Feb 28, 2024
Merged
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Feb 28, 2024
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (fb6efca) to main (8990023).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 0f18001 into psf:main Feb 28, 2024
@cobaltt7 cobaltt7 deleted the refactor-delimiter-split branch February 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

skip news Pull requests that don't need a changelog entry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cobaltt7 @JelleZijlstra