Skip to content

Conversation

rdubya
Copy link

@rdubya rdubya commented Jan 8, 2021

This fixes #8191

@acozzette
Copy link
Contributor

Thanks, @rdubya! I believe you will need to add the new test files here to fix the test failures.

@rdubya
Copy link
Author

rdubya commented Jan 13, 2021

Hey @acozzette, sorry about missing that step again. I also updated the test structure to match the other ruby tests better.

@rdubya
Copy link
Author

rdubya commented Jan 13, 2021

@acozzette are those failures something else I need to change? The details links don't give me any info.

@acozzette
Copy link
Contributor

@rdubya Sorry about that, I can't see any details either. Let me rerun the tests and see if we get more informative results. If that doesn't fix it then there might be another problem because we have been having some issues with access to the test logs.

@acozzette acozzette merged commit 48234f5 into protocolbuffers:master Jan 14, 2021
@rdubya rdubya deleted the fix-nested-messages branch January 14, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ruby] JRuby - problems with nested messages

3 participants