Skip to content

Remove GOOGLE_PROTOBUF_SUPPORT_SYSTEM_MEMORY #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

Remove GOOGLE_PROTOBUF_SUPPORT_SYSTEM_MEMORY #8011

merged 1 commit into from
Nov 6, 2020

Conversation

JamesNK
Copy link
Contributor

@JamesNK JamesNK commented Nov 5, 2020

Compiler flag GOOGLE_PROTOBUF_SUPPORT_SYSTEM_MEMORY is no longer needed. It is always true.

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@JamesNK
Copy link
Contributor Author

JamesNK commented Nov 5, 2020

re: #7645 (comment)

@jtattermusch

@JamesNK JamesNK mentioned this pull request Nov 5, 2020
Merged
jtattermusch
jtattermusch approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, LGTM!

@jtattermusch jtattermusch merged commit 0bb6dd8 into protocolbuffers:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c# cla: yes cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesNK @jtattermusch @protobuf-kokoro