Skip to content

PHP typehints for message setters #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2018
Merged

PHP typehints for message setters #4533

merged 1 commit into from
Jun 19, 2018

Conversation

bshaffer
Copy link
Contributor

same as #3331, but to the php-generated-dev branch

This adds typehints for all Message setters. A few other interesting things have happened as a result:

  1. Setters for Message types no longer pass-by-reference, since this is implicit for PHP objects
  2. Setters for Message types now accept an optional null, since the base Message class requires passing null to the public setters in order for the method clear() to work.

@xfxyjwf xfxyjwf requested a review from TeBoring April 23, 2018 20:54
@anandolee
Copy link
Contributor

ping @TeBoring

2 similar comments
@xfxyjwf
Copy link
Contributor

xfxyjwf commented May 14, 2018

ping @TeBoring

@xfxyjwf
Copy link
Contributor

xfxyjwf commented May 21, 2018

ping @TeBoring

@anandolee anandolee added the php label Jun 18, 2018
@TeBoring TeBoring merged commit abac808 into protocolbuffers:php-generated-dev Jun 19, 2018
@bshaffer bshaffer deleted the php-typehints-generated-dev branch January 11, 2019 21:07
@bshaffer bshaffer mentioned this pull request Jan 31, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Feb 14, 2025
@bshaffer @copybara-github
feat(php): improve return typehint when repeatedfield (#11734)
e04fe69 
Adds the type of the `RepeatedField` to the PHPDoc, e.g.

```php
/**
 * @return \Google\Protobuf\Internal\RepeatedField<int>
 */
```

Whereas before, the `<int>` part was not included.

This is the "getter" counterpart for #4533

Closes #11734

PiperOrigin-RevId: 726881276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TeBoring TeBoring TeBoring approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@TeBoring TeBoring

Labels
cla: yes php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bshaffer @anandolee @xfxyjwf @TeBoring @googlebot