Explicitly specify pyext/cpp_message.py in py_modules list #3

dhirschfeld · 2014-08-27T08:26:02Z

No description provided.

xfxyjwf · 2014-08-27T17:48:01Z

I'm not sure whether this is the right change. My understanding is that cpp_message.py is only used for Python CPPv1. We probably should delete it instead.

dhirschfeld · 2014-09-01T18:49:02Z

There are 2 implementations of cpp_message, one in internal which @gpshead says in issue #2 should have been deleted.

There's a second implementation in pyext which seems to be a lightweight wrapper over the cpp _message module which seems to be required because its referenced in reflection.py.

Without specifying cpp_message.py in thge py_modules list neither cpp_message.py, nor the __init__.py are copied to the pyext module hence _message.pyd isn't importable in the resulting package. if the second pyext\cpp_message.py module isn't required perhaps the __init__.py will have to be specified to force it to appear in the resulting python package

Explicitly specify pyext/cpp_message.py in py_modules list

xfxyjwf · 2014-10-02T22:55:45Z

This should fixes issue #34

Provide UT that reproduces issue protocolbuffers#3

==500166==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xdd383e in google::protobuf::compiler::DiskSourceTree::OpenDiskFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:504:7 #1 0xdd1eb2 in google::protobuf::compiler::DiskSourceTree::DiskFileToVirtualFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:431:51 #2 0x540619 in google::protobuf::compiler::CommandLineInterface::MakeProtoProtoPathRelative(google::protobuf::compiler::DiskSourceTree*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, google::protobuf::DescriptorDatabase*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1362:24 #3 0x5314fb in google::protobuf::compiler::CommandLineInterface::MakeInputsBeProtoPathRelative(google::protobuf::compiler::DiskSourceTree*, google::protobuf::DescriptorDatabase*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1415:10 #4 0x5314fb in google::protobuf::compiler::CommandLineInterface::InitializeDiskSourceTree(google::protobuf::compiler::DiskSourceTree*, google::protobuf::DescriptorDatabase*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1168:8 #5 0x52541f in google::protobuf::compiler::CommandLineInterface::Run(int, char const* const*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1026:10 #6 0x50f5d6 in google::protobuf::compiler::ProtobufMain(int, char**) build_msan/./contrib/protobuf/src/google/protobuf/compiler/main.cc:104:14 protocolbuffers#7 0x50fe58 in main build_msan/./contrib/protobuf/src/google/protobuf/compiler/main.cc:112:10 protocolbuffers#8 0x7f817143db24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24) protocolbuffers#9 0x48904d in _start (/mnt/ch/ClickHouse/build_msan/contrib/protobuf-cmake/protoc+0x48904d) Uninitialized value was created by an allocation of 'sb' in the stack frame of function '_ZN6google8protobuf8compiler14DiskSourceTree12OpenDiskFileERKNSt3__112basic_stringIcNS3_11char_traitsIcEENS3_9allocatorIcEEEE' #0 0xdd3320 in google::protobuf::compiler::DiskSourceTree::OpenDiskFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:492 SUMMARY: MemorySanitizer: use-of-uninitialized-value build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:504:7 in google::protobuf::compiler::DiskSourceTree::OpenDiskFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) Exiting

PiperOrigin-RevId: 573295697

PiperOrigin-RevId: 573556031

==500166==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xdd383e in google::protobuf::compiler::DiskSourceTree::OpenDiskFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:504:7 #1 0xdd1eb2 in google::protobuf::compiler::DiskSourceTree::DiskFileToVirtualFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:431:51 #2 0x540619 in google::protobuf::compiler::CommandLineInterface::MakeProtoProtoPathRelative(google::protobuf::compiler::DiskSourceTree*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, google::protobuf::DescriptorDatabase*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1362:24 #3 0x5314fb in google::protobuf::compiler::CommandLineInterface::MakeInputsBeProtoPathRelative(google::protobuf::compiler::DiskSourceTree*, google::protobuf::DescriptorDatabase*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1415:10 #4 0x5314fb in google::protobuf::compiler::CommandLineInterface::InitializeDiskSourceTree(google::protobuf::compiler::DiskSourceTree*, google::protobuf::DescriptorDatabase*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1168:8 #5 0x52541f in google::protobuf::compiler::CommandLineInterface::Run(int, char const* const*) build_msan/./contrib/protobuf/src/google/protobuf/compiler/command_line_interface.cc:1026:10 #6 0x50f5d6 in google::protobuf::compiler::ProtobufMain(int, char**) build_msan/./contrib/protobuf/src/google/protobuf/compiler/main.cc:104:14 protocolbuffers#7 0x50fe58 in main build_msan/./contrib/protobuf/src/google/protobuf/compiler/main.cc:112:10 protocolbuffers#8 0x7f817143db24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24) protocolbuffers#9 0x48904d in _start (/mnt/ch/ClickHouse/build_msan/contrib/protobuf-cmake/protoc+0x48904d) Uninitialized value was created by an allocation of 'sb' in the stack frame of function '_ZN6google8protobuf8compiler14DiskSourceTree12OpenDiskFileERKNSt3__112basic_stringIcNS3_11char_traitsIcEENS3_9allocatorIcEEEE' #0 0xdd3320 in google::protobuf::compiler::DiskSourceTree::OpenDiskFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:492 SUMMARY: MemorySanitizer: use-of-uninitialized-value build_msan/./contrib/protobuf/src/google/protobuf/compiler/importer.cc:504:7 in google::protobuf::compiler::DiskSourceTree::OpenDiskFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) Exiting

``` int com.google.android.test.Outer.computeUInt32SizeNoTag(int) [24 bytes] 0x000024d0 mov w0, #0x160 0x000024d4 clz w1, w1 0x000024d8 add w1, w1, w1, lsl #3 0x000024dc sub w0, w0, w1 0x000024e0 lsr w0, w0, #6 0x000024e4 ret ``` versus existing: ``` int com.google.android.test.Outer.computeUInt32SizeNoTag(int) [72 bytes] 0x000022a0 and w0, w1, #0xffffff80 0x000022a4 cbnz w0, #+0xc (addr 0x22b0) 0x000022a8 mov w0, #0x1 0x000022ac b #+0x38 (addr 0x22e4) 0x000022b0 and w0, w1, #0xffffc000 0x000022b4 cbnz w0, #+0xc (addr 0x22c0) 0x000022b8 mov w0, #0x2 0x000022bc b #+0x28 (addr 0x22e4) 0x000022c0 and w0, w1, #0xffe00000 0x000022c4 cbnz w0, #+0xc (addr 0x22d0) 0x000022c8 mov w0, #0x3 0x000022cc b #+0x18 (addr 0x22e4) 0x000022d0 mov w2, #0x5 0x000022d4 mov w0, #0x4 0x000022d8 and w1, w1, #0xf0000000 0x000022dc cmp w1, #0x0 (0) 0x000022e0 csel w0, w2, w0, ne 0x000022e4 ret ``` PiperOrigin-RevId: 584143825

``` int com.google.android.test.Outer.computeUInt32SizeNoTag(int) [24 bytes] 0x000024d0 mov w0, #0x160 0x000024d4 clz w1, w1 0x000024d8 add w1, w1, w1, lsl #3 0x000024dc sub w0, w0, w1 0x000024e0 lsr w0, w0, #6 0x000024e4 ret ``` versus existing: ``` int com.google.android.test.Outer.computeUInt32SizeNoTag(int) [72 bytes] 0x000022a0 and w0, w1, #0xffffff80 0x000022a4 cbnz w0, #+0xc (addr 0x22b0) 0x000022a8 mov w0, #0x1 0x000022ac b #+0x38 (addr 0x22e4) 0x000022b0 and w0, w1, #0xffffc000 0x000022b4 cbnz w0, #+0xc (addr 0x22c0) 0x000022b8 mov w0, #0x2 0x000022bc b #+0x28 (addr 0x22e4) 0x000022c0 and w0, w1, #0xffe00000 0x000022c4 cbnz w0, #+0xc (addr 0x22d0) 0x000022c8 mov w0, #0x3 0x000022cc b #+0x18 (addr 0x22e4) 0x000022d0 mov w2, #0x5 0x000022d4 mov w0, #0x4 0x000022d8 and w1, w1, #0xf0000000 0x000022dc cmp w1, #0x0 (0) 0x000022e0 csel w0, w2, w0, ne 0x000022e4 ret ``` PiperOrigin-RevId: 591113652

…ted_headers Update list of headers

…take #3) PiperOrigin-RevId: 673536874

…take #3 but disabled) PiperOrigin-RevId: 673536874

…take #3 but disabled) PiperOrigin-RevId: 675266565

…take #3 but disabled) PiperOrigin-RevId: 675319986

Before: ``` ldrh w8, [x1, #6] sxth x9, w8 and w8, w8, #0x7 lsr x9, x9, #3 ldrb w9, [x0, x9] lsr w8, w9, w8 and w0, w8, #0x1 ret ``` After: ``` ldrh w8, [x1, #6] lsr x9, x8, #3 and w8, w8, #0x7 ldrb w9, [x0, x9] lsr w8, w9, w8 and w0, w8, #0x1 ret ``` PiperOrigin-RevId: 735497444

Before: ``` ldrh w8, [x1, #6] sxth x9, w8 and w8, w8, #0x7 lsr x9, x9, #3 ldrb w9, [x0, x9] lsr w8, w9, w8 and w0, w8, #0x1 ret ``` After: ``` ldrh w8, [x1, #6] lsr x9, x8, #3 and w8, w8, #0x7 ldrb w9, [x0, x9] lsr w8, w9, w8 and w0, w8, #0x1 ret ``` PiperOrigin-RevId: 735610397

Explicitly specify pyext/cpp_message.py in py_modules list

ef6eff2

xfxyjwf assigned mrovner Sep 4, 2014

Catstyle mentioned this pull request Sep 23, 2014

compile and install python module failed #34

Closed

xfxyjwf added a commit that referenced this pull request Oct 2, 2014

Merge pull request #3 from dhirschfeld/pyext-fix

eb223ed

Explicitly specify pyext/cpp_message.py in py_modules list

xfxyjwf merged commit eb223ed into protocolbuffers:master Oct 2, 2014

dhirschfeld deleted the pyext-fix branch October 13, 2014 09:18

cloudkey mentioned this pull request Feb 4, 2015

FileDescriptorTables *** glibc detected *** double free or corruption (out) #194

Closed

xfxyjwf mentioned this pull request May 26, 2015

Distribute well-known types protos in release packages. #289

Closed

lostindark mentioned this pull request Mar 15, 2016

[feature request] scoped enums with an option #1079

Closed

pwtitle mentioned this pull request Dec 21, 2016

class Descriptor does not exists #2527

Closed

roczpwu mentioned this pull request Jul 21, 2017

protobuf-3.3.2 segment fault: 11 #3402

Closed

FZUPotato mentioned this pull request Aug 21, 2017

coredump under the MIPS64 architecture #3532

Closed

jakiechris mentioned this pull request Nov 20, 2017

[solved, pls close this issue] protobuf crashes on android 4.4.2 on Huawei p7 #3922

Closed

E-HERO mentioned this pull request Dec 3, 2017

proto used by executable file and shared lib crash #3991

Closed

ujmedia mentioned this pull request Jul 23, 2018

terminate called after throwing an instance of 'std::system_error' - after switching to version 3.6.0 (from 3.5.1) #4958

Closed

google-admin unassigned mrovner Aug 21, 2018

catskul mentioned this pull request Aug 21, 2018

Problems with Python Layer: Protobuf Internal Error - Mutex Lock #3671

Closed

arnow117 mentioned this pull request Apr 1, 2019

python: SIGSEGV when use PyImport_Import import symbol_database #5979

Closed

elad-maimon mentioned this pull request Jul 28, 2019

Support extensions for proto2 in Ruby? #6420

Closed

sunbibei mentioned this pull request Sep 26, 2019

-m32 is not compatible with -freg-struct-return #6700

Closed

asraa mentioned this pull request Nov 15, 2019

Fix some UBsan warnings #6896

Merged

jschultz410 mentioned this pull request Feb 20, 2020

Missing value/null support for scalar value types in proto 3 #1606

Closed

PierrickVoulet pushed a commit to PierrickVoulet/protobuf that referenced this pull request May 27, 2020

Provide UT that reproduces issue protocolbuffers#3

15fa089

PierrickVoulet pushed a commit to PierrickVoulet/protobuf that referenced this pull request May 28, 2020

Merge pull request protocolbuffers#5 from PierrickVoulet/testIssue3

335e663

Provide UT that reproduces issue protocolbuffers#3

snehasinha13 mentioned this pull request Sep 30, 2020

Weird SIGSEGV in protobuf import #7931

Closed

doom-goober mentioned this pull request Oct 17, 2020

JsonParser.withIgnoreUnknownFields true will now ignore unknown enums. #7974

Closed

xianggao mentioned this pull request Oct 27, 2021

core dump initializing at google::protobuf::internal::EpsCopyInputStream::ReadString #9163

Closed

blacktek mentioned this pull request Sep 22, 2022

Protobuf PHP compiled library segmentation faults googleads/google-ads-php#845

Closed

slotherhouse mentioned this pull request Dec 1, 2022

EOF inside bytes field error occurs when exceeding specific length of bytes #11112

Closed

AlexeiKharchev mentioned this pull request May 1, 2023

pthread_key_delete(key_) failed with error 22 #12617

Closed

rong-lai mentioned this pull request Jul 25, 2023

Occasional coredump occurred when using ParseFromString #13387

Closed

copybara-service bot pushed a commit that referenced this pull request Oct 13, 2023

Use GetArena() instead of GetOwningArena() #3.

14ffc8e

PiperOrigin-RevId: 573295697

copybara-service bot mentioned this pull request Oct 13, 2023

Use GetArena() instead of GetOwningArena() #3. #14395

Closed

copybara-service bot pushed a commit that referenced this pull request Oct 15, 2023

Use GetArena() instead of GetOwningArena() #3.

8a3eb71

PiperOrigin-RevId: 573295697

copybara-service bot pushed a commit that referenced this pull request Oct 15, 2023

Use GetArena() instead of GetOwningArena() #3.

3bd0f35

PiperOrigin-RevId: 573556031

babuveld mentioned this pull request Jan 12, 2024

route_guide_server process core seen during string encode in linux 32bit #15418

Closed

M-Labedzki mentioned this pull request May 23, 2024

Invalid symbol name: google.protobuf.@ #16940

Closed

GerHobbelt pushed a commit to GerHobbelt/protobuf that referenced this pull request Aug 4, 2024

Merge pull request protocolbuffers#3 from Esri/marc9905/ftAnno43_upda…

5fd29a6

…ted_headers Update list of headers

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

3f3ed59

…take #3) PiperOrigin-RevId: 673536874

copybara-service bot mentioned this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (take #3 but disabled) #18280

Closed

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

749678c

…take #3 but disabled) PiperOrigin-RevId: 673536874

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

bf4f64e

…take #3 but disabled) PiperOrigin-RevId: 675266565

copybara-service bot mentioned this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (take #3 but disabled) #18346

Merged

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

4db7af1

…take #3 but disabled) PiperOrigin-RevId: 675266565

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

1227811

…take #3 but disabled) PiperOrigin-RevId: 675266565

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

c5c5090

…take #3 but disabled) PiperOrigin-RevId: 675266565

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

25a4f9f

…take #3 but disabled) PiperOrigin-RevId: 675266565

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

4879a92

…take #3 but disabled) PiperOrigin-RevId: 675266565

copybara-service bot pushed a commit that referenced this pull request Sep 16, 2024

Make WireFormat::(ByteSize|_InternalSerialize) LazyField compatible (…

c860fa3

…take #3 but disabled) PiperOrigin-RevId: 675319986

fbucafusco mentioned this pull request Nov 19, 2024

[C++] core dump when ParsePartialFromArray is called #19315

Closed

xuquanwei2019 mentioned this pull request Jun 27, 2025

AddDescriptors is not thread safe, but multi-thread access may occur when the SO is opened through dlopen #22425

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Explicitly specify pyext/cpp_message.py in py_modules list #3

Explicitly specify pyext/cpp_message.py in py_modules list #3

Uh oh!

dhirschfeld commented Aug 27, 2014

Uh oh!

xfxyjwf commented Aug 27, 2014

Uh oh!

dhirschfeld commented Sep 1, 2014

Uh oh!

xfxyjwf commented Oct 2, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Explicitly specify pyext/cpp_message.py in py_modules list #3

Explicitly specify pyext/cpp_message.py in py_modules list #3

Uh oh!

Conversation

dhirschfeld commented Aug 27, 2014

Uh oh!

xfxyjwf commented Aug 27, 2014

Uh oh!

dhirschfeld commented Sep 1, 2014

Uh oh!

xfxyjwf commented Oct 2, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants