Weaken vulnerable gencode poison pills to warning by default. #21688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a new option that opts back into the exception.
esrauchg
requested review from
mkruskal-google and
shaod2
and removed request for
a team
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
shaod2
approved these changes
May 9, 2025
java/core/src/test/java/com/google/protobuf/GeneratedMessagePre22ErrorTest.java
Outdated
Show resolved
Hide resolved
java/core/src/test/java/com/google/protobuf/GeneratedMessagePre22ErrorTest.java
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
esrauchg
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
zhangskz
reviewed
May 9, 2025
java/core/src/test/java/com/google/protobuf/GeneratedMessagePre22ErrorTest.java
Outdated
Show resolved
Hide resolved
zhangskz
approved these changes
May 9, 2025
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous change, an exception was added when vulnerable gencode was used with an opt out env variable.
With this change, the default behavior is reduced to printing a warning (with a stack trace). The preexisting env variable can still be used to completely silence this behavior, a new env variable is added to opt back into the behavior of throwing the exception.