Register Scalar/MessageMapContainerTypes as virtual subclasses of MutableMapping instead of inheriting directly. #15999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_609782761
branch
3 times, most recently
from
2bee52f to
80e7375
Compare
…ableMapping instead of inheriting directly. This prevents these from using abc.ABCMeta metaclass to avoid deprecation warning: ``` DeprecationWarning: Type google._upb._message.MessageMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14. ``` Fixes #15077 Fixes #12186 PiperOrigin-RevId: 613029479
copybara-service
bot
force-pushed
the
test_609782761
branch
from
80e7375 to
5b32936
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
5b32936
1 task
|
It seems likely that GCP's |
andife
pushed a commit
to onnx/onnx
that referenced
this pull request
Oct 20, 2025
### Motivation and Context We are seeing test errors on MacOS and Python 3.14. These errors come from Protobuf and they were fixed in #protocolbuffers/protobuf#15999 and the PR was contained since 6.31.0. Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register Scalar/MessageMapContainerTypes as virtual subclasses of MutableMapping instead of inheriting directly.
This prevents these from using abc.ABCMeta metaclass to avoid deprecation warning:
Fixes #15077
Fixes #12186