protobuf-2.6.1 doesn't support Solaris on amd64.

[jspal]

google/protobuf/stubs/atomicops_internals_solaris.h: No such file or directory

The file has not been included in protobuf-2.6.1.tar.gz

So after:
./configure LDFLAGS=-L$PWD/src/solaris --disable-64bit-solaris --prefix=/alocation/protobuf32-2.6.1
it fails to make.

( uname -a -> SunOS mxcapd11 5.10 Generic_150401-05 i86pc i386 i86pc )

[xfxyjwf]

Ops.. I just checked-in some new tarballs, can you help check whether they work on solaris?
https://github.com/google/protobuf/blob/fix/dist/protobuf-2.6.1.tar.gz

[jspal]

Hello,
For sure.

I’d like to build a 32-bit version on Solaris.
For ./configure I’m using:

./configure CXX=CC CC=CC LDFLAGS=-L$PWD/src/solaris --disable-64bit-solaris --prefix=/alocation/google/protobuf32-2.6.1.1

CC -> /opt/solstudio12.2/bin/CC

$ CC –V
CC: Sun C++ 5.11 SunOS_i386 2010/08/13

Your latest tarball gets further this time but now fails with:

"./google/protobuf/stubs/platform_macros.h", line 90: Error: "," expected instead of ""Host platform was not detected as supported by protobuf"".

on compiling the first file, i.e.
libtool: compile: CC -DHAVE_CONFIG_H -I. -I.. -D_REENTRANT -pthreads -g0 -xO3 -xlibmil -xdepend -xbuiltin -mt -compat=5 -library=stlport4 -library=Crun -template=no%extdef -DNDEBUG -c google/protobuf/stubs/atomicops_internals_x86_gcc.cc -KPIC -DPIC -o google/protobuf/stubs/.libs/atomicops_internals_x86_gcc.o

On my hardware ( uname –a -> SunOS ahost 5.10 Generic_150401-05 i86pc i386 i86pc & isainfo –kv -> 64-bit amd64 kernel modules )
there’s no predefined macro for sparc
but there is a predefined macro for sun (and __sun)

I’m thinking the required resolved pre-processor directive for my 32-bit build should be:
#define GOOGLE_PROTOBUF_ARCH_32_BIT 1

Regards

From: Feng Xiao [mailto:notifications@github.com]
Sent: 22 October 2014 19:47
To: google/protobuf
Cc: Spalek, John
Subject: Re: [protobuf] protobuf-2.6.1.tar.gz missing solaris header (#63)

Ops.. I just checked-in some new tarballs, can you help check whether they work on solaris?
https://github.com/google/protobuf/blob/fix/dist/protobuf-2.6.1.tar.gz

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-60134744.

[xfxyjwf]

Hmm, so the platform_macros.h header file only supports Solaris on sparc CPU. Could you help check which macro your compiler has defined and maybe send us a fix for this? I would think it should have defined the i386 macro but apparently it doesn't.

[jspal]

The macros defined by compiler are:
CC -xdumpmacros -E /dev/null
#1 "/dev/null"

#define cplusplus 199711L
#define __STDC 0
#define _WCHAR_T
#define _BOOL 1
#define __ARRAYNEW 1
#define DATE "Oct 24 2014"
#define TIME "13:48:15"
#define LINE
#define FILE
#define SIGNEDCHAR 1
#define PRAGMA_REDEFINE_EXTNAME 1
#define __asm asm
#define __asm asm
#define volatile volatile
#define __volatile volatile
#define attribute __attribute
#define alignof __alignof
#define __SunOS_5_10 1
#define __SUNPRO_CC 0x5110
#define __unix 1
#define __SVR4 1
#define __sun 1
#define __SunOS 1
#define __i386 1
#define __BUILTIN_VA_ARG_INCR 1
#define unix 1
#define sun 1
#define i386 1
#define __SUN_PREFETCH 1
#define __SUNPRO_CC_COMPAT 5

That shows i386. Which to me implies a 32-bit x86, which is odd since this is a 64-bit OS ( 64-bit amd64 kernel modules )

My attempt at a change to "google/protobuf/stubs/platform_macros.h" is:

#elif defined(pnacl)
#define GOOGLE_PROTOBUF_ARCH_32_BIT 1
#elif defined(sun)
#if defined(sparc)
#define GOOGLE_PROTOBUF_ARCH_SPARC 1
#endif
#if defined SOLARIS_64BIT_ENABLED
#define GOOGLE_PROTOBUF_ARCH_64_BIT 1
#else
#define GOOGLE_PROTOBUF_ARCH_32_BIT 1
#endif
#elif defined(GNUC)

i.e. add a #elif for sun around existing sparc stuff, and default to GOOGLE_PROTOBUF_ARCH_32_BIT

Now make gets further, until it hits the link error:
Undefined first referenced
symbol in file
const char*google::protobuf::compiler::java::FieldTypeName(const google::protobuf::FieldDescriptor::Type) google/protobuf/compiler/java/.libs/java_extension.o
ld: fatal: symbol referencing errors. No output written to .libs/libprotoc.so.9.0.1

You need add const to the definition of:
const char* FieldTypeName(const FieldDescriptor::Type field_type) {
at line 329 in google/protobuf/compiler/java/ java_helpers.cc

Also to remove these warnings,
"./google/protobuf/descriptor.h", line 373: Warning: Identifier expected instead of "}".
"./google/protobuf/descriptor.h", line 392: Warning: Identifier expected instead of "}".
"./google/protobuf/descriptor.h", line 403: Warning: Identifier expected instead of "}".
"./google/protobuf/wire_format_lite.h", line 93: Warning: Identifier expected instead of "}".
"./google/protobuf/wire_format_lite.h", line 116: Warning: Identifier expected instead of "}".
"./google/protobuf/wire_format_lite.h", line 131: Warning: Identifier expected instead of "}".
"./google/protobuf/wire_format.h", line 228: Warning: Identifier expected instead of "}".
"./google/protobuf/compiler/command_line_interface.h", line 317: Warning: Identifier expected instead of "}".
remove the trailing comma from the last enum in the list.

This now produces ./protoc, but this protoc fails to run due to compiling with -pthreads. So I changed ./configure to

./configure CXX=CC CC=CC PTHREAD_CFLAGS=-mt LDFLAGS=-L$PWD/src/solaris --disable-64bit-solaris --prefix=/alocation/google/protobuf32-2.6.1.1

Which now produces 32-bit binaries in src/.libs for protoc, libprotoc,so & libprotoc-lite.so

Next:
make check fails with:
$ make check
Making check in .
make check-local
Making lib/libgtest.a lib/libgtest_main.a in gtest
source='src/gtest-all.cc' object='src/gtest-all.lo' libtool=yes
DEPDIR=.deps depmode=none /bin/bash ./build-aux/depcomp
/bin/bash ./libtool --tag=CXX --mode=compile CC -DHAVE_CONFIG_H -I. -I./build-aux -I. -I./include -D_REENTRANT -mt -DGTEST_HAS_PTHREAD=1 -g0 -xO3 -xlibmil -xdepend -xbuiltin -mt -compat=5 -library=stlport4 -library=Crun -template=no%extdef -DNDEBUG -c -o src/gtest-all.lo src/gtest-all.cc
libtool: compile: CC -DHAVE_CONFIG_H -I. -I./build-aux -I. -I./include -D_REENTRANT -mt -DGTEST_HAS_PTHREAD=1 -g0 -xO3 -xlibmil -xdepend -xbuiltin -mt -compat=5 -library=stlport4 -library=Crun -template=no%extdef -DNDEBUG -c src/gtest-all.cc -KPIC -DPIC -o src/.libs/gtest-all.o
"./src/gtest-printers.cc", line 269: Error: Could not find a match for PrintAsStringLiteralTo needed in testing::internal::PrintCharsAsStringTo(const char_, unsigned, std::ostream *).
"./src/gtest-printers.cc", line 316: Where: While instantiating "testing::internal::PrintCharsAsStringTo(const char_, unsigned, std::ostream )".
"./src/gtest-printers.cc", line 316: Where: Instantiated from non-template code.
1 Error(s) detected.
** Error code 1

At which point I give up for today.

From: Feng Xiao [mailto:notifications@github.com]
Sent: 23 October 2014 19:45
To: google/protobuf
Cc: Spalek, John
Subject: Re: [protobuf] protobuf-2.6.1 doesn't support Solaris on amd64. (#63)

Hmm, so the platform_macros.h header file only supports Solaris on sparc CPU. Could you help check which macro your compiler has defined and maybe send us a fix for this? I would think it should have defined the i386 macro but apparently it doesn't.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-60288810.

[jspal]

Any news/help on this?

[xfxyjwf]

As we don't have a Solaris machine to test this by ourselves we will need users' help to fix this problem. Could you help send us a patch for this?

[phansson]

@jspal I notice you're compiling using the Solaris Studio compiler. Try compiling using GNU C/C++ compiler instead.

If not installed then do as follows:

pkg install pkg://solaris/developer/build/gnu-make
pkg install pkg://solaris/developer/gcc-45
pkg install pkg://solaris/system/header
pkg install pkg://solaris/developer/build/autoconf
pkg install pkg://solaris/developer/build/automake-110

Actually not sure they are all needed for Protobuf.

Here are some general guidelines (not specific to Protobuf). I've stolen them from here.

General recommendations when building software packages on Solaris

So you grabbed a software package from the Internet and now want to build it on Solaris ? Here are some general recommendations:

• Always use GNU tar to unpack, don't use Solaris' own tar. So do gtar xf foo.tar rather than tar xf foo.tar or whatever. Yes in 99.99% of the cases Solaris' tar will work just fine for you but there are some subtle differences between the two for example if the tar file contains soft links.
• Use GNU make rather than Solaris' make For example when you are told to do this: make all then instead do MAKE=gmake gmake all.
• You will generally have less trouble using GNU C/C++ to build rather than Solaris Studio because chances are that the makefiles and the compile options etc have only been tested with GNU C/C++ compiler.