Skip to content

Bump actions/checkout from 3.6.0 to 4.1.7 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

mmorel-35
Copy link
Contributor

Hi @Nexucis,

We missed this one ;) !

@@ -3,7 +3,7 @@ description: An action used by the Prometheus project to share github actions.
runs:
using: composite
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
Copy link
Contributor Author

@mmorel-35 mmorel-35 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall the ref be updated when the release is created ?

- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
    repository: 'prometheus/promci'
    path: '.github/promci'
    ref: v0.4.0

for the next release for example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed you are right, we should update the ref.

Signed-off-by: Matthieu MOREL <[email protected]>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks for the changes !

@Nexucis Nexucis merged commit 69ee4ea into prometheus:main Aug 22, 2024
1 check passed
@mmorel-35 mmorel-35 deleted the root-checkout branch August 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants