Skip to content

Conversation

luizluca
Copy link
Contributor

For prometheus/node_exporter#2044

Signed-off-by: Luiz Angelo Daros de Luca [email protected]

@luizluca luizluca force-pushed the scsitape branch 2 times, most recently from c389393 to aa33d7b Compare May 24, 2021 16:57
@luizluca
Copy link
Contributor Author

Is there anything else pending?

Signed-off-by: Luiz Angelo Daros de Luca <[email protected]>
@luizluca
Copy link
Contributor Author

luizluca commented Jun 8, 2021

I just forced-push the review suggestions. I'll do the same for node_exporter collector.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ requested a review from discordianfish June 23, 2021 08:22
@discordianfish discordianfish merged commit 953e37b into prometheus:master Jul 1, 2021
@discordianfish
Copy link
Member

Awesome, thanks @luizluca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants