Skip to content

Fix mdadm collector issues #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Fix mdadm collector issues #985

merged 1 commit into from
Jul 2, 2018

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Jun 26, 2018

  • Send "Personality unknown" to debug, not info, remove unnecessary newline.
  • Add support for "linear" personality.
  • Always set number of active disks to 0 when a device is inactive.
  • Add total disks calculation to unknown personalites.

Signed-off-by: Ben Kochie [email protected]

Closes: #984

@SuperQ SuperQ requested a review from discordianfish June 26, 2018 11:11
@SuperQ SuperQ force-pushed the bjk/mdadm_log branch 3 times, most recently from 952e030 to 307c37f Compare June 26, 2018 12:14
* Send "Personality unknown" to debug, not info, remove unnecessary newline.
* Add support for "linear" personality.
* Always set number of active disks to 0 when a device is inactive.
* Add total disks calculation to unknown personalites.

Signed-off-by: Ben Kochie <[email protected]>
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 107e5df into master Jul 2, 2018
@SuperQ SuperQ deleted the bjk/mdadm_log branch July 2, 2018 10:38
jan--f pushed a commit to jan--f/node_exporter that referenced this pull request May 23, 2019
Was fixed upstream in
prometheus#985 or v0.17.0

Signed-off-by: Jan Fajerski <[email protected]>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* Send "Personality unknown" to debug, not info, remove unnecessary newline.
* Add support for "linear" personality.
* Always set number of active disks to 0 when a device is inactive.
* Add total disks calculation to unknown personalites.

Signed-off-by: Ben Kochie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants