Skip to content

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Oct 25, 2025

Add metrics for Zswap and Zswapped to the meminfo collector.

Fixes: #3449

Add metrics for Zswap and Zswapped to the meminfo collector.

Fixes: #3449

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ requested a review from gouthamve October 25, 2025 12:17
@SuperQ SuperQ merged commit cc2212b into master Oct 25, 2025
14 checks passed
@SuperQ SuperQ deleted the superq/zswap branch October 25, 2025 13:45
SuperQ added a commit that referenced this pull request Oct 25, 2025
* [BUGFIX] filesystem: Fix mount points being collected multiple times #3376
* [BUGFIX] filesystem: Refactor mountinfo parsing #3452
* [BUGFIX] meminfo: Add Zswap/Zswapped metrics #3453

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ mentioned this pull request Oct 25, 2025
SuperQ added a commit that referenced this pull request Oct 25, 2025
* [BUGFIX] filesystem: Fix mount points being collected multiple times #3376
* [BUGFIX] filesystem: Refactor mountinfo parsing #3452
* [BUGFIX] meminfo: Add Zswap/Zswapped metrics #3453

Signed-off-by: Ben Kochie <[email protected]>
metrics["WritebackTmp_bytes"] = float64(*meminfo.WritebackTmpBytes)
}
if meminfo.ZswapBytes != nil {
metrics["Zswap_ytes"] = float64(*meminfo.ZswapBytes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it a typo ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing metric node_memory_Zswap_bytes

3 participants