additional metrics for pcidevice and id to name conversion #3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SuperQ , this is a continuation of prometheus/procfs#748. Has some additional features as well. Please take a look and share your thoughts. |
|
Released and updated procfs. #3444 Please rebase. 🎉 |
* add sriov, power info support and pci id name resolution Signed-off-by: Jain Johny <[email protected]> * fix/remove debug lines Signed-off-by: Jain Johny <[email protected]> --------- Signed-off-by: Jain Johny <[email protected]>
* add numa_node and missing test output file Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
SuperQ
reviewed
Oct 22, 2025
Signed-off-by: Jain Johny <[email protected]>
SuperQ
reviewed
Oct 22, 2025
SuperQ
reviewed
Oct 22, 2025
|
|
||
| pcideviceNumaNodeDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, pcideviceSubsystem, "numa_node"), | ||
| "NUMA node number for the PCI device. -1 indicates unknown or not available.", |
There was a problem hiding this comment.
Do we want to just not emit the metric if it's unknown / not available?
|
Looks good, a couple questions. |
Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
Signed-off-by: Jain Johny <[email protected]>
SuperQ
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this PR.
[1] Enabling additional metrics including SRIOV, power management details and numa node of the pci device. This depends on prometheus/procfs#748
[2] Optional (disabled by default) feature to convert pci vendor/device/class ids to names from the system pci.ids file or a file passed as argument.
I had an internal repo where I had done this earlier. Recently saw the PR for pcidevice_linux.go and thought it will be a good idea to add my work into the same collector.
I have also added nil pointer checks to all optional fields in sysfs.PciDevice struct.
I understand that some might find [2] unnecessary, but it has been very useful in our use cases (both LLM and human use). Hence I have added it but kept disabled by default. Please let me know your thoughts. @discordianfish
PS: Tests are failing because of the dependency on prometheus/procfs#748