Skip to content

Add AIX support #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 28, 2024
Merged

Add AIX support #3136

merged 9 commits into from
Sep 28, 2024

Conversation

discordianfish
Copy link
Member

This PR adds a basic set of AIX metrics, including a dashboard for the mixins:
image

Since adding tests is hard due to the unavailability of AIX test runners, I carefully manually verified the metrics: https://docs.google.com/document/d/1_9cPbLTNqrxIeTZ57ZbyVsgOurvzvEKy67GvSNSrOhk/edit?usp=sharing

Thanks to Grafana for sponsoring this work!

Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]>
@discordianfish discordianfish merged commit b5ce6bc into master Sep 28, 2024
8 checks passed
@discordianfish discordianfish deleted the add-aix-support branch September 28, 2024 13:58
@dmytrobabeshko
Copy link

dmytrobabeshko commented Oct 2, 2024

@discordianfish
Could you please advise on how to build this for aix/ppc64? Any guidance you can provide would be greatly appreciated.
Adding aix/ppc64 platform to .promu-cgo.yml falling to gccgo: error: unrecognized command-line option '-maix64' error

Building with promu --config .promu-cgo.yml crossbuild

@discordianfish
Copy link
Member Author

@dmytrobabeshko you should able to build it using golang directly, a go build should be sufficient. I haven't looked into crosscompiling.

SuperQ added a commit that referenced this pull request Feb 16, 2025
* [CHANGE] meminfo: Convert linux implementation to use procfs lib #3049
* [CHANGE] Update logging to use Go log/slog #3097
* [FEATURE] filesystem: Add `node_filesystem_mount_info` metric #2970
* [FEATURE] btrfs: Add metrics for commit statistics #3010
* [FEATURE] interrupts: Add collector include/exclude filtering #3028
* [FEATURE] interrupts: Add "exclude zeros" filtering #3028
* [FEATURE] slabinfo: Add filters for slab name. #3041
* [FEATURE] pressure: add IRQ PSI metrics #3048
* [FEATURE] hwmon: Add include and exclude filter for sensors #3072
* [FEATURE] filesystem: Add NetBSD support #3082
* [FEATURE] netdev: Add ifAlias label #3087
* [FEATURE] hwmon: Add Support for GPU Clock Frequencies #3093
* [FEATURE] Add `exclude[]` URL parameter #3116
* [FEATURE] Add AIX support #3136
* [FEATURE] filesystem: Add fs-types/mount-points include flags #3171
* [FEATURE] netstat: Add collector for tcp packet counters for FreeBSD. #3177
* [ENHANCEMENT] ethtool: Add logging for filtering flags #2979
* [ENHANCEMENT] netstat: Add TCPRcvQDrop to default metrics #3021
* [ENHANCEMENT] diskstats: Add block device rotational #3022
* [ENHANCEMENT] cpu: Support CPU online status #3032
* [ENHANCEMENT] arp: optimize interface name resolution #3133
* [ENHANCEMENT] textfile: Allow specifiying multiple directory globs #3135
* [ENHANCEMENT] filesystem: Add reporting of purgeable space on MacOS #3206
* [ENHANCEMENT] ethtool: Skip full scan of NetClass directories #3239
* [BUGFIX] zfs: Prevent `procfs` integer underflow #2961
* [BUGFIX] pressure: Fix collection on systems that do not expose a full CPU stat #3054
* [BUGFIX] cpu: Fix FreeBSD 32-bit host support and plug memory leak #3083
* [BUGFIX] hwmon: Add safety check to hwmon read #3134
* [BUGFIX] zfs: Allow space in dataset name #3186

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ mentioned this pull request Feb 16, 2025
SuperQ added a commit that referenced this pull request Feb 17, 2025
* [CHANGE] meminfo: Convert linux implementation to use procfs lib #3049
* [CHANGE] Update logging to use Go log/slog #3097
* [FEATURE] filesystem: Add `node_filesystem_mount_info` metric #2970
* [FEATURE] btrfs: Add metrics for commit statistics #3010
* [FEATURE] interrupts: Add collector include/exclude filtering #3028
* [FEATURE] interrupts: Add "exclude zeros" filtering #3028
* [FEATURE] slabinfo: Add filters for slab name. #3041
* [FEATURE] pressure: add IRQ PSI metrics #3048
* [FEATURE] hwmon: Add include and exclude filter for sensors #3072
* [FEATURE] filesystem: Add NetBSD support #3082
* [FEATURE] netdev: Add ifAlias label #3087
* [FEATURE] hwmon: Add Support for GPU Clock Frequencies #3093
* [FEATURE] Add `exclude[]` URL parameter #3116
* [FEATURE] Add AIX support #3136
* [FEATURE] filesystem: Add fs-types/mount-points include flags #3171
* [FEATURE] netstat: Add collector for tcp packet counters for FreeBSD. #3177
* [ENHANCEMENT] ethtool: Add logging for filtering flags #2979
* [ENHANCEMENT] netstat: Add TCPRcvQDrop to default metrics #3021
* [ENHANCEMENT] diskstats: Add block device rotational #3022
* [ENHANCEMENT] cpu: Support CPU online status #3032
* [ENHANCEMENT] arp: optimize interface name resolution #3133
* [ENHANCEMENT] textfile: Allow specifiying multiple directory globs #3135
* [ENHANCEMENT] filesystem: Add reporting of purgeable space on MacOS #3206
* [ENHANCEMENT] ethtool: Skip full scan of NetClass directories #3239
* [BUGFIX] zfs: Prevent `procfs` integer underflow #2961
* [BUGFIX] pressure: Fix collection on systems that do not expose a full CPU stat #3054
* [BUGFIX] cpu: Fix FreeBSD 32-bit host support and plug memory leak #3083
* [BUGFIX] hwmon: Add safety check to hwmon read #3134
* [BUGFIX] zfs: Allow space in dataset name #3186

Signed-off-by: Ben Kochie <[email protected]>
@veso0308
Copy link

Thank you for having merged this feature.
In the 1.9.0 release, the aix binaries seem to be missing. Is this a bug or should I use another binary?
@SuperQ @discordianfish
Thanks in advance.

@SuperQ
Copy link
Member

SuperQ commented Feb 17, 2025

Release binary platforms need to be added to .promu-cgo.yml in order to be included.

@veso0308
Copy link

Thank you! I've created a Pull Request: #3250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants