Skip to content

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented May 21, 2024

@SuperQ SuperQ requested a review from gouthamve May 21, 2024 16:41
prombot and others added 5 commits May 21, 2024 18:47
* Sign node exporter darwin binary with rcodesign

Prevents SIGKILL issues on macs

Signed-off-by: Alper Polat <[email protected]>

* Be explicit about checking for the binary

Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Alper Polat <[email protected]>

* Also attempt to sign darwin-amd64

Signed-off-by: Alper Polat <[email protected]>

---------

Signed-off-by: Alper Polat <[email protected]>
Signed-off-by: Alper Polat <[email protected]>
Co-authored-by: Ben Kochie <[email protected]>
Replace all cpu_ticks_* with cpu_nsec_*, since the former was off my a
magnitude of 10e6, and showed incorrect values for
node_cpu_seconds_total.

Fixes: #1837

Signed-off-by: Pranshu Srivastava <[email protected]>
Check that the PSI metrics are returned in order to avoid nil pointer
dereference.
* Update fixutre to match real-world samples.

Fixes: #3015

Signed-off-by: Ben Kochie <[email protected]>
* [BUGFIX] Fix CPU seconds on Solaris #2963
* [BUGFIX] Sign Darwin/MacOS binaries #3008
* [BUGFIX] Fix pressure collector nil reference #3016

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ force-pushed the superq/release-1.8.1 branch from 3fa877a to 81b00bb Compare May 21, 2024 16:47
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 400c397 into release-1.8 May 21, 2024
@SuperQ SuperQ deleted the superq/release-1.8.1 branch May 21, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants