Skip to content

Conversation

tklauser
Copy link
Contributor

Use SysctlTimeval from the golang.org/x/sys/unix package to
simplify the implementation of the boottime collector for the BSDs and
allows to build it without cgo.

Tested on macOS 11.6, FreeBSD 13 and OpenBSD 7.

Use SysctlTimeval from the golang.org/x/sys/unix package to
simplify the implementation of the boottime collector for the BSDs and
allows to build it without cgo.

Tested on macOS 11.6, FreeBSD 13 and OpenBSD 7.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the boottime-bsd-simplify branch from 556c0ab to 78b34a4 Compare November 13, 2021 09:46
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like there are still some other CGO requirements for various BSDs, so we can't say "no CGO" yet.

But, progress.

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah neat, thanks!

@discordianfish discordianfish merged commit 58ab014 into prometheus:master Nov 15, 2021
@tklauser tklauser deleted the boottime-bsd-simplify branch November 15, 2021 09:58
@juzhao juzhao mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants