-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Collect additional common Infiniband counters #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! You also need to update |
It looks like you've incorrectly merged an upstream commit into your branch. I would suggest looking at GitHub fork workflow. You want to work on a local branch, rather than the master of your fork. This will avoid these kind of merge errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, Please add an [ENHANCEMENT]
entry in the CHANGELOG under master / unreleased
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Patrick Freeman <[email protected]>
Signed-off-by: Patrick Freeman <[email protected]>
Signed-off-by: Patrick Freeman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Collect additional common Infiniband counters Signed-off-by: Patrick Freeman <[email protected]> Signed-off-by: iori-yja <[email protected]>
* Collect additional common Infiniband counters Signed-off-by: Patrick Freeman <[email protected]>
* Collect additional common Infiniband counters Signed-off-by: Patrick Freeman <[email protected]>
No description provided.