Don't ignore unit if NRestarts isn't available #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a duplicate of #1038. |
|
@SuperQ That was one was |
|
@fastest963 Nice, thanks! |
SuperQ
reviewed
Aug 7, 2018
collector/systemd_linux.go
Outdated
| } | ||
| unit.currentConnections = currentConnectionCount.Value.Value().(uint32) | ||
|
|
||
| // NRefused wasn't added until systemd 239 |
There was a problem hiding this comment.
Nit, please end comments with a .
|
Would you mind updating the commit description with a full list of changes? Also, please update the |
|
Beside @SuperQ's comment, LGTM! |
* If NRestarts or NRefused are not available, don't ignore the unit itself * Don't report systemd metrics (NRestarts/NRefused) that are not available Signed-off-by: James Hartig <[email protected]>
|
Thanks @SuperQ and @discordianfish! I just updated the commit message and changelog. I filed the ignoring units as BUGFIX and the not reporting as CHANGE, let me know if that's sufficient. |
|
@fastest963 ugh, sorry about that. Thank you for fixing! |
|
@fastest963 Great, thanks! Just a final rebase to solve the changelog conflicts and we can merge this. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
…metheus#1039) * If NRestarts or NRefused are not available, don't ignore the unit itself * Don't report systemd metrics (NRestarts/NRefused) that are not available Signed-off-by: James Hartig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #1036. The latest systemd in our CentOS is not new enough to have NRestarts so this effectively means the systemd collector cannot collect any services. Instead of ignoring a service without NRestarts, just log and leave it at 0.
Fixes: #567
@SuperQ @discordianfish