prometheus/collectors: use godoc link for runtime/metrics supported metrics #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieyuschen
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
kakkoyun
approved these changes
Jul 29, 2025
|
@xieyuschen Thanks for the contribution. You need to sign your commits. Please check the failing CI step. |
…etrics This pr replaces the link from src/runtime/metrics/description.go to runtime/metrics package docs. The change is reasonable as: - go doc has integrated go version switch, but old link cannot change it via web ui. - the package docs is sufficient to show all provided metrics from runtime, we don't need to see code even it's not complex. Signed-off-by: xieyuschen <[email protected]>
|
done, thanks for your review:) @kakkoyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr repalces the link from src/runtime/metrics/description.go to runtime/metrics package docs. The change is reasonable as:
@ArthurSens