pinger: support horizon of observed UUID generations #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ObserviceGenerationsCount tracks number of most recent number of UUID generations which should be observer by Pinger. This allows to reduce amount of memory Pinger can utilize for observing old non-responded packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix leaking memory in case of non-responding endpoints.
This work is similar to #33 and #9 however with very simple implementation.
I do not insist on merging this particular solution, however in our case we were unable to use pro-bing for long-running Pinger's on production due to slowly, however consistently increasing memory consumption.
This problem should be address by any of PRs