-
Notifications
You must be signed in to change notification settings - Fork 784
Add a collector for pg_buffercache_summary
.
#1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2abb5c9
Add a collector for `pg_buffercache`.
sfc-gh-pnuttall 6014965
Update collector/pg_buffercache.go
sfc-gh-pnuttall 64f002f
Rename `s/pg_buffercache/pg_buffercache_summary/`.
sfc-gh-pnuttall 93a7548
Merge branch 'bufcache' of github.com:Snowflake-Labs/postgres_exporte…
sfc-gh-pnuttall aa004f6
Update collector/pg_buffercache_summary.go
sfc-gh-pnuttall 6e53796
Move gaugeInt32 into collector.go.
sfc-gh-pnuttall 62bcb12
copyright
sfc-gh-pnuttall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
// Copyright The Prometheus Authors | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package collector | ||
|
||
import ( | ||
"context" | ||
"database/sql" | ||
"log/slog" | ||
|
||
"github.com/blang/semver/v4" | ||
"github.com/prometheus/client_golang/prometheus" | ||
) | ||
|
||
const buffercacheSummarySubsystem = "buffercache_summary" | ||
|
||
func init() { | ||
registerCollector(buffercacheSummarySubsystem, defaultDisabled, NewBuffercacheSummaryCollector) | ||
} | ||
|
||
// BuffercacheSummaryCollector collects stats from pg_buffercache: https://www.postgresql.org/docs/current/pgbuffercache.html. | ||
// | ||
// It depends on the extension being loaded with | ||
// | ||
// create extension pg_buffercache; | ||
// | ||
// It does not take locks, see the PG docs above. | ||
type BuffercacheSummaryCollector struct { | ||
log *slog.Logger | ||
} | ||
|
||
func NewBuffercacheSummaryCollector(config collectorConfig) (Collector, error) { | ||
return &BuffercacheSummaryCollector{ | ||
log: config.logger, | ||
}, nil | ||
} | ||
|
||
var ( | ||
buffersUsedDesc = prometheus.NewDesc( | ||
prometheus.BuildFQName(namespace, buffercacheSummarySubsystem, "buffers_used"), | ||
"Number of used shared buffers", | ||
[]string{}, | ||
prometheus.Labels{}, | ||
) | ||
buffersUnusedDesc = prometheus.NewDesc( | ||
prometheus.BuildFQName(namespace, buffercacheSummarySubsystem, "buffers_unused"), | ||
"Number of unused shared buffers", | ||
[]string{}, | ||
prometheus.Labels{}, | ||
) | ||
buffersDirtyDesc = prometheus.NewDesc( | ||
prometheus.BuildFQName(namespace, buffercacheSummarySubsystem, "buffers_dirty"), | ||
"Number of dirty shared buffers", | ||
[]string{}, | ||
prometheus.Labels{}, | ||
) | ||
buffersPinnedDesc = prometheus.NewDesc( | ||
prometheus.BuildFQName(namespace, buffercacheSummarySubsystem, "buffers_pinned"), | ||
"Number of pinned shared buffers", | ||
[]string{}, | ||
prometheus.Labels{}, | ||
) | ||
usageCountAvgDesc = prometheus.NewDesc( | ||
prometheus.BuildFQName(namespace, buffercacheSummarySubsystem, "usagecount_avg"), | ||
"Average usage count of used shared buffers", | ||
[]string{}, | ||
prometheus.Labels{}, | ||
) | ||
|
||
buffercacheQuery = ` | ||
SELECT | ||
buffers_used, | ||
buffers_unused, | ||
buffers_dirty, | ||
buffers_pinned, | ||
usagecount_avg | ||
FROM | ||
pg_buffercache_summary() | ||
` | ||
) | ||
|
||
// Update implements Collector | ||
// It is called by the Prometheus registry when collecting metrics. | ||
func (c BuffercacheSummaryCollector) Update(ctx context.Context, instance *instance, ch chan<- prometheus.Metric) error { | ||
// pg_buffercache_summary is only in v16, and we don't need support for earlier currently. | ||
if !instance.version.GE(semver.MustParse("16.0.0")) { | ||
return nil | ||
} | ||
db := instance.getDB() | ||
rows, err := db.QueryContext(ctx, buffercacheQuery) | ||
if err != nil { | ||
return err | ||
} | ||
defer rows.Close() | ||
|
||
var used, unused, dirty, pinned sql.NullInt32 | ||
var usagecountAvg sql.NullFloat64 | ||
|
||
for rows.Next() { | ||
if err := rows.Scan( | ||
&used, | ||
&unused, | ||
&dirty, | ||
&pinned, | ||
&usagecountAvg, | ||
); err != nil { | ||
return err | ||
} | ||
|
||
usagecountAvgMetric := 0.0 | ||
if usagecountAvg.Valid { | ||
usagecountAvgMetric = usagecountAvg.Float64 | ||
} | ||
ch <- prometheus.MustNewConstMetric( | ||
usageCountAvgDesc, | ||
prometheus.GaugeValue, | ||
usagecountAvgMetric) | ||
ch <- prometheus.MustNewConstMetric(buffersUsedDesc, prometheus.GaugeValue, Int32(used)) | ||
ch <- prometheus.MustNewConstMetric(buffersUnusedDesc, prometheus.GaugeValue, Int32(unused)) | ||
ch <- prometheus.MustNewConstMetric(buffersDirtyDesc, prometheus.GaugeValue, Int32(dirty)) | ||
ch <- prometheus.MustNewConstMetric(buffersPinnedDesc, prometheus.GaugeValue, Int32(pinned)) | ||
} | ||
|
||
return rows.Err() | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// Copyright 2023 The Prometheus Authors | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
package collector | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/DATA-DOG/go-sqlmock" | ||
"github.com/blang/semver/v4" | ||
"github.com/prometheus/client_golang/prometheus" | ||
dto "github.com/prometheus/client_model/go" | ||
"github.com/smartystreets/goconvey/convey" | ||
) | ||
|
||
func TestBuffercacheSummaryCollector(t *testing.T) { | ||
db, mock, err := sqlmock.New() | ||
if err != nil { | ||
t.Fatalf("Error opening a stub db connection: %s", err) | ||
} | ||
defer db.Close() | ||
|
||
inst := &instance{db: db, version: semver.MustParse("16.0.0")} | ||
|
||
columns := []string{ | ||
"buffers_used", | ||
"buffers_unused", | ||
"buffers_dirty", | ||
"buffers_pinned", | ||
"usagecount_avg"} | ||
|
||
rows := sqlmock.NewRows(columns).AddRow(123, 456, 789, 234, 56.6778) | ||
|
||
mock.ExpectQuery(sanitizeQuery(buffercacheQuery)).WillReturnRows(rows) | ||
|
||
ch := make(chan prometheus.Metric) | ||
go func() { | ||
defer close(ch) | ||
c := BuffercacheSummaryCollector{} | ||
|
||
if err := c.Update(context.Background(), inst, ch); err != nil { | ||
t.Errorf("Error calling PGStatStatementsCollector.Update: %s", err) | ||
} | ||
}() | ||
|
||
expected := []MetricResult{ | ||
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 56.6778}, | ||
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 123}, | ||
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 456}, | ||
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 789}, | ||
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 234}, | ||
} | ||
|
||
convey.Convey("Metrics comparison", t, func() { | ||
for _, expect := range expected { | ||
m := readMetric(<-ch) | ||
convey.So(expect, convey.ShouldResemble, m) | ||
} | ||
}) | ||
if err := mock.ExpectationsWereMet(); err != nil { | ||
t.Errorf("there were unfulfilled exceptions: %s", err) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.