Skip to content

fix(roles/_common): Fix non-boolean conditionals #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(roles/_common): Fix non-boolean conditionals #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/_common/tasks/configure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
become: true
notify:
- "{{ ansible_parent_role_names | first }} : Restart {{ _common_service_name }}"
when: (_common_config_dir)
when: _common_config_dir is defined
tags:
- "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}"
- configure
Expand Down
2 changes: 1 addition & 1 deletion roles/_common/tasks/install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
- name: "Verify checksum of {{ __common_binary_basename }}"
run_once: true
check_mode: false
when: (_common_checksums_url)
when: _common_checksums_url is defined
block:
- name: "Fetch checksum list for {{ __common_binary_basename }}"
ansible.builtin.uri:
Expand Down
4 changes: 2 additions & 2 deletions roles/_common/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
ansible.builtin.package:
name: "{{ _common_dependencies }}"
state: present
when: (_common_dependencies)
when: _common_dependencies is defined
tags:
- "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}"
- configure
Expand All @@ -84,4 +84,4 @@
reject('match', '.+:\\d+$') |
list |
length == 0
when: (_common_web_listen_address)
when: _common_web_listen_address is defined
Loading