Syntax 0.8, part 7: \UHHHHHH and other changes #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
zeroeight-part7
branch
from
4e6cfc1 to
b2a932e
Compare
|
This PR depends on #313 which hasn't been merged yet. @Pike, if you want to review this first, the compare view might be helpful. Thanks. |
Pike
approved these changes
Nov 29, 2018
| for (let i = 0; i < 4; i++) { | ||
| const ch = ps.takeHexDigit(); | ||
| getUnicodeEscapeSequence(ps, u, digits) { | ||
| ps.expectChar(u); |
There was a problem hiding this comment.
We already checked this in the switch statement, I'd just ps.next() here, and drop the u argument.
There was a problem hiding this comment.
I'd prefer to keep expectChar. In fact, I'm planning a clean up after 0.8 where we get rid of most of ps.next(). I always seem to forget what it's supposed to consume, something expectChar is very explicit about.
There was a problem hiding this comment.
Oh, and we need the u arg for the error message. That's the real reason why it's there.
For compatibility with the reference parser which used to use the /./
regex, the tooling parser used to recognize additional EOL characters in
Comments. This has since been fixed in the reference parser:
projectfluent/fluent@2d224cb
stasm
force-pushed
the
zeroeight-part7
branch
from
b2a932e to
c8ecf45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement part 7 of #303.
Recognize \UHHHHHH as an escape sequence fluent#201, tooling parser, runtime parser
Change line endings in comments to line_end fluent#219, tooling parser
Forbid nested VariantLists fluent#220, tooling parser