Skip to content

Conversation

dogancanbakir
Copy link
Member

Proposed changes

Closes #4706

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dogancanbakir dogancanbakir self-assigned this Jan 31, 2024
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! later on maybe we can add a flag or env variable to choose user agents based on specific tags (ex: mobile etc)

@ehsandeep
Copy link
Member

lgtm ! later on maybe we can add a flag or env variable to choose user agents based on specific tags (ex: mobile etc)

For now, we are keeping latest / computer browser UA's only as different type of UA's producing diffrent response causing issues with result consistency.

@ehsandeep ehsandeep merged commit 5f4dcfb into dev Jan 31, 2024
@ehsandeep ehsandeep deleted the use_useragent branch January 31, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace corpix/uarand with projectdiscovery/useragent
3 participants