Skip to content

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jul 27, 2023

Proposed changes

Introducing http connection reuse for RFC-compliant http requests with host-spray strategy

Depends on projectdiscovery/retryablehttp-go#105

Note: the current number of parallel connections per host with host-spray strategy should probably be lowered to the number of -c (concurrent templates) and without/high rate-limit as everything will go through the same connections to the same target

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 self-assigned this Jul 27, 2023
Mzack9999 and others added 2 commits July 27, 2023 19:09
probably should be set to a lower number to push connection reuse
Base automatically changed from dev to v3-beta August 4, 2023 14:51
@tarunKoyalwar tarunKoyalwar changed the base branch from v3-beta to dev August 4, 2023 15:02
@Mzack9999 Mzack9999 marked this pull request as ready for review August 25, 2023 13:42
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint error

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit 28be967 into dev Sep 4, 2023
@ehsandeep ehsandeep deleted the feat-conn branch September 4, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants