Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently Nuclei integrates with templates on an S3 bucket by downloading all files to disk, saving to the
CustomS3TemplateDirectory
, then reads the templates from disk. The disk I/O is not ideal for serverless workloads and this PR adds an AWS Catalog implementation similar todisk.DiskCatalog
.This will allow users to pull templates directly from S3 storage and the content is read directly from the S3 download without writing to disk.
I did not remove or alter the AWS S3 code in the
customtemplates
package to avoid impacting any current use cases that leverage the existing S3 implementation.Usage
Replacing
disk.NewCatalog()
withaws.NewCatalog()
will leverage AWS S3 for retrieving templates.Checklist