Skip to content

Adding proxy use in headless binary download #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2023
Merged

Adding proxy use in headless binary download #3290

merged 2 commits into from
Feb 9, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Feb 8, 2023 •
edited
Loading

Proposed changes

This PR forces ignore TLS certificates via reflection within go rod (partial patch at go-rod/rod#763)

Depends on projectdiscovery/utils#78

image

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 8, 2023
@Mzack9999 Mzack9999 self-assigned this Feb 8, 2023
@Mzack9999 Mzack9999 linked an issue Feb 8, 2023 that may be closed by this pull request
Download of chromium does not honor proxy settings #2582
Closed
@Mzack9999 Mzack9999 marked this pull request as draft February 8, 2023 11:25
@Mzack9999 Mzack9999 marked this pull request as ready for review February 9, 2023 09:54
@ehsandeep ehsandeep merged commit 518944f into dev Feb 9, 2023
@ehsandeep ehsandeep deleted the issue-2582-rod-proxy branch February 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download of chromium does not honor proxy settings
2 participants
@Mzack9999 @ehsandeep