Skip to content

adding json schema for extractor #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2023
Merged

adding json schema for extractor #3240

merged 2 commits into from
Feb 7, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 26, 2023 •
edited
Loading

Proposed changes

This PR (hopefully) fixes #3105 by adding JSON schema attributes that should overwrite mandatorily required one

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 26, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 26, 2023
@Mzack9999 Mzack9999 linked an issue Jan 26, 2023 that may be closed by this pull request
yaml Schema extractors tags require DSL tags #3105
Closed
@ehsandeep ehsandeep requested a review from Ice3man543 February 2, 2023 12:22
@ehsandeep ehsandeep merged commit 1fbd2c0 into dev Feb 7, 2023
@ehsandeep ehsandeep deleted the issue-3105-extract-json-schema branch February 7, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yaml Schema extractors tags require DSL tags
3 participants
@Mzack9999 @Ice3man543 @ehsandeep