Skip to content

Conversation

jonathanwalker
Copy link
Contributor

Proposed changes

Updated golang example in the Using Nuclei From Go Code section as []string{"docs.hackerone.com"} is not a valid input. It requires type []*contextargs.MetaInput. Confirmed working example.

Also noted that pkg.go.dev fails to interpret the MIT license, probably due to license file name being updated.

Checklist

Updating README so performed no checks, tests, and documentation

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep requested a review from Mzack9999 December 27, 2022 17:25
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - follow up ticket #3096

@ehsandeep ehsandeep merged commit 8003f38 into projectdiscovery:dev Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants