Add flag to golangci-lint to show line number if there is error

[lubronzhan]

Fix #6095
Example run after adding the change in my PR
#6073
projectcontour/contour/actions/runs/7551166827/job/20557981226?pr=6073

run golangci-lint
  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --build-tags=e2e,conformance,gcp,oidc,none --out-${NO_FUTURE}format=colored-line-number] in [] ...
  Error: internal/provisioner/objects/rbac/role/role.go:100:45: unused-parameter: parameter 'namespace' seems to be unused, consider removing or renaming it as _ (revive)
  func desiredRoleForContourInNamespace(name, namespace string, contour *model.Contour) *rbacv1.Role {
                                              ^
  Error: internal/provisioner/objects/rbac/role/role.go:117:121: updateRoleIfNeeded - result 0 (*k8s.io/api/rbac/v1.Role) is never used (unparam)
  func updateRoleIfNeeded(ctx context.Context, cli client.Client, contour *model.Contour, current, desired *rbacv1.Role) (*rbacv1.Role, error) {
                                                                                                                          ^
  Error: issues found

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (572515a) 78.85% compared to head (9d59072) 78.85%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6096   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files         138      138           
  Lines       19731    19731           
=======================================
  Hits        15558    15558           
  Misses       3870     3870           
  Partials      303      303           

[tsaarni]

Thanks @lubronzhan! This seems the way to go, though I cannot figure out why this is not the default, as discussed at length here golangci/golangci-lint-action#119

By default golangci-lint-action runs golangci-lint with --output-format=github-action. When user gives --out-format=colored-line-number the format will be concatenated and result will be both --out-format=github-actions,colored-line-number (according to golangci/golangci-lint-action#769) giving best of both worlds: annotations (annotations.png from workflow commands) as well as line numbers in logs!

[skriss]

LGTM