release-1.25: Bump client-go to 1.26.7 #5595
Conversation
Includes fixes that ensure compatibility with k8s 1.27 clusters See kubernetes/kubernetes#118361 for context Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
requested review from
tsaarni and
stevesloka
and removed request for
a team
sunjayBhatia
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.25 #5595 +/- ##
=============================================
Coverage 77.84% 77.85%
=============================================
Files 138 138
Lines 18296 18294 -2
=============================================
Hits 14243 14243
+ Misses 3779 3777 -2
Partials 274 274
|
Further compatibility with 1.27 Signed-off-by: Sunjay Bhatia <[email protected]>
| // Returning error will avoid handlers from being called. | ||
| // This does not avoid caching. | ||
| return nil, fmt.Errorf("ignoring secret %s/%s of type %s", secret.Namespace, secret.Name, secret.Type) | ||
| return secret, nil |
There was a problem hiding this comment.
we can't return an error here with the updated handling of the transformer func, see: kubernetes/client-go@fffc68d
There was a problem hiding this comment.
Looks consistent with what we did when we upgraded to 1.27 deps (#5362), 👍
There was a problem hiding this comment.
contour informers don't sync and this error is repeatedly logged without this
time="2023-07-26T20:27:34Z" level=error msg="pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1.Secret: unable to sync list result: couldn't enqueue object: ignoring secret kube-system/bootstrap-token-abcdef of type bootstrap.kubernetes.io/token\n" caller="reflector.go:140" context=kubernetes error="<nil>"
Includes fixes that ensure compatibility with k8s 1.27 clusters
See kubernetes/kubernetes#118361 for context