internal/envoy/v3: RouteConfiguration ignores port when choosing virtualhost #5437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ualhost Previously we stripped the port from the Host header when matching a virtualhost, which also resulted in the header being modified for the downstream. For Gateway API conformance, we no longer want to do this. This basically reverts projectcontour#3458 and uses the newer RouteConfiguration field that allows us to ignore port when choosing a virtualhost. We reintroduce the logic in the SNI/Host misdirected request Lua to strip the port when checking the hostname against SNI. Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
added
the
release-note/small
sunjayBhatia
requested review from
tsaarni,
stevesloka and
skriss
and removed request for
a team
sunjayBhatia
added
release-note/minor
Signed-off-by: Sunjay Bhatia <[email protected]>
|
huh the ingress test fails but almost identical gateway one passes |
|
ah, the header regex match on a single DNS label seems to be doing it, it relies on the port not being present |
needs to ignore port if present Signed-off-by: Sunjay Bhatia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5437 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 138 138
Lines 18496 18496
=======================================
Hits 14462 14462
Misses 3757 3757
Partials 277 277
|
skriss
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we stripped the port from the Host header when matching a virtualhost, which also resulted in the header being modified for the downstream. For Gateway API conformance, we no longer want to do this.
This basically reverts #3458 and uses the newer RouteConfiguration field that allows us to ignore port when choosing a virtualhost. We reintroduce the logic in the SNI/Host misdirected request Lua to strip the port when checking the hostname against SNI.