internal/sorter: Routes with method matching get precedence #5434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjayBhatia
added
the
release-note/minor
sunjayBhatia
requested review from
tsaarni,
stevesloka and
skriss
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5434 +/- ##
=======================================
Coverage ? 78.21%
=======================================
Files ? 138
Lines ? 18517
Branches ? 0
=======================================
Hits ? 14483
Misses ? 3757
Partials ? 277
|
skriss
reviewed
Jun 5, 2023
This is to support Gateway API conformance, release 0.7.1 dictates that HTTP method comes before length of header matches in the precendence order for choosing routes. Since we currently implement method matching in the DAG by adding a :method header match, this solution finds any :method headers being matched on and first determines precendence of two routes being compared based on that. If method matches are equal (both present or not present), then we go ahead with comparing the remaining header matches. Since HTTPProxy provides this ability as well, this will affect priority of routes from HTTPProxies, not just Gateway API HTTPRoute. Alternately we could add a method field directly to the dag.Route struct and implement method matching that way. We may want to in that case also sanitize the header matches to make sure we properly collect matches on the :method header, or disallow using them in HTTPRoute, etc. Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
force-pushed
the
method-matching-precedence
branch
from
8848f64 to
62ca3e7
Compare
Signed-off-by: Sunjay Bhatia <[email protected]>
skriss
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support Gateway API conformance, release 0.7.1 dictates that HTTP method comes before length of header matches in the precendence order for choosing routes.
Since we currently implement method matching in the DAG by adding a :method header match, this solution finds any :method headers being matched on and first determines precedence of two routes being compared based on that. If method matches are equal (both present or not present), then we go ahead with comparing the remaining header matches.
Since HTTPProxy provides this ability as well, this will affect priority of routes from HTTPProxies, not just Gateway API HTTPRoute.
Alternately we could add a method field directly to the dag.Route struct and implement method matching that way. We may want to in that case also sanitize the header matches to make sure we properly collect matches on the :method header, or disallow using them in HTTPRoute, etc.
See gateway API docs: https://github.com/kubernetes-sigs/gateway-api/blob/v0.7.1/apis/v1beta1/httproute_types.go#L163-L167